The MCHMappingFactory library will disappear in O2#372
Merged
Barthelemy merged 2 commits intoAliceO2Group:masterfrom Apr 20, 2020
Merged
Conversation
This commit lets the MCH QC Module handle gracefully that removal.
Contributor
Author
|
@Barthelemy Don't know if you apply the "no merge on Friday afternoon"'s rule ;-) but in case you don't, could you please consider merging this one ? It would unblock AliceO2Group/AliceO2#3313. Thanks. |
Collaborator
|
@aphecetche I did not see your comment until now, so that resolves the question :) merging now |
Barthelemy
approved these changes
Apr 20, 2020
Contributor
Author
|
@Barthelemy Thanks. But I guess I'd also need to "bump" the QC recipe to use the version that has this fix, otherwise the PR AliceO2Group/AliceO2#3313 will keep failing, right ? (currently it is using v0.25.1) |
Collaborator
|
you are correct, I will make a new release |
Collaborator
Barthelemy
pushed a commit
to Barthelemy/QualityControl
that referenced
this pull request
Apr 28, 2020
* The MCHMappingFactory library will disappear in O2 This commit lets the MCH QC Module handle gracefully that removal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit lets the MCH QC Module handle gracefully that removal.
The function, CreateSegmentation, that is provided by the MCHMappingFactory, will still exist, but will be defined in the MCHMappingInterface library instead.
This QualityControl PR will in turn will allow the O2 PR AliceO2Group/AliceO2#3313 to succeed the O2 suite check.